search

jonmcalder / refactor

:bookmark: Better factor handling for R
https://jonmcalder.github.io/refactor/
MIT License
3 stars 0 forks source link

relationship of the arguments right and balance. #2

Closed lorenzwalthert closed 8 years ago

lorenzwalthert commented 8 years ago

Problem

If length(breaks) == 1, the option right remains without effect, whereas in the case of length(breaks) > 1, the option balance remains without effect but no message is issued.

Suggested solution

Since both options refer to more or less the same (if not exactly the same), we should only keep one.

jonmcalder commented 8 years ago

Intuitively I utilised separate parameters since they are applied in different contexts but I agree that this is probably not necessary. Let's keep the 'right' argument, and update code functionality and documentation to reflect the different ways the parameter can be 'interpreted' for each context.

On Sun, 4 Sep 2016, 20:10 lorwal, notifications@github.com wrote:

Problem

If length(breaks) == 1, the option right remains without effect, whereas in the case of length(breaks) > 1, the option balance remains without effect but no message is issued. Suggested solution

Since both options refer to more or less the same (if not exactly the same), we should only keep one.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jonmcalder/refactor/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AE0lSunV2YOXHcsl4IFnd-leCB1uezZtks5qmwmSgaJpZM4J0l6L .