jonmcalder / refactor

:bookmark: Better factor handling for R
https://jonmcalder.github.io/refactor/
MIT License
3 stars 0 forks source link

Styler #24

Closed lorenzwalthert closed 7 years ago

lorenzwalthert commented 7 years ago

check how well styler styles our grand old refactor package 😊. Not yet to be merged.

codecov-io commented 7 years ago

Codecov Report

Merging #24 into master will increase coverage by <.01%. The diff coverage is 98.73%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24      +/-   ##
=======================================
+ Coverage      99%   99%   +<.01%     
=======================================
  Files           8     8              
  Lines         400   402       +2     
=======================================
+ Hits          396   398       +2     
  Misses          4     4
Impacted Files Coverage Δ
R/cut_helper.R 100% <100%> (ø) :arrow_up:
R/cc.R 100% <100%> (ø) :arrow_up:
R/append.R 100% <100%> (ø) :arrow_up:
R/cut.ordered.R 100% <100%> (ø) :arrow_up:
R/cfactor.R 98.92% <100%> (ø) :arrow_up:
R/ifelse.R 100% <100%> (ø) :arrow_up:
R/cut.integer.R 98.93% <100%> (ø) :arrow_up:
R/index_cfactor.R 95.91% <93.54%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df8e877...dc69ca1. Read the comment docs.

lorenzwalthert commented 7 years ago

Quite a bit of work left for styler...

lorenzwalthert commented 7 years ago

Ok, at least curly braces should be fixed now with PR #109 in styler.

lorenzwalthert commented 7 years ago

@jonmcalder can you review quickly? I think styler is now kind of complete (this styling is based on a few dev branch merges) cc @krlmlr Will add stuff that is not yet merged into master via PRs.

jonmcalder commented 7 years ago

Sorry I've been away on holiday the past few days. Heading back home tomorrow though so should review within the next 48 hours.

lorenzwalthert commented 7 years ago

No hurries. 😊

lorenzwalthert commented 7 years ago

Uups. Beginner's mistake😊. Sure.

lorenzwalthert commented 7 years ago

Awww... I guess now it's fine.