response_modifier: response modification working end to end - Githubissues

jonmorehouse / gatekeeper

a pluggable http routing runtime

12 stars 1 forks source link

response_modifier: response modification working end to end #34

Closed jonmorehouse closed 8 years ago

jonmorehouse commented 8 years ago

So a few tasks to follow up on after this PR lands...

[ ] content-length / body overrides' don't seem to be working 100% perfectly
[ ] the proxier class seems inefficient there's going to be contention in the director override callback, it seems like; though let's wait for that to happen before optimizing.
[ ] this PR really shows off that we need to consolidate the request / response modifiers.

Other than that, this all is working correctly; it was pretty awesome to override a response from a plugin just to play around with it :)