upstreams: enforce name uniqueness

jonmorehouse / gatekeeper

a pluggable http routing runtime

12 stars 1 forks source link

upstreams: enforce name uniqueness #59

Closed jonmorehouse closed 8 years ago

jonmorehouse commented 8 years ago

Doing this over in mysql-api-upstreams plugin. Simplifies things, drastically!

Also - we should add some validation around naming.

jonmorehouse commented 8 years ago

Actually - let's just be smarter about id's ...

Let's switch things up to ...

id: passed in by the user and is the "name"
name: the "human readable" version of the name

jonmorehouse commented 8 years ago

I think we should enforce "name" uniqueness in gatekeeper (should be fairly easy, actually).

but I don't think we need to remove the "id" and do that like mentioned before. This was a side effect of tunnel vision while working on mysql-api-upstreams as we were trying to do some "magic".

jonmorehouse commented 8 years ago

Furthermore - we should build id's in mysql and those will be guaranteed to be unique. In the off-chance that someone has configured more than a single plugin, there is a chance that we could have duplicate IDs which we'll need to handle in gatekeeper (I think we already do, but still).