RPC discussion - Githubissues

jonnew / cyclops

Precision current source, with optional optical feedback, for driving LEDs and laser diodes

https://open-ephys.org/cyclops-led-driver/cyclops-led-driver

45 stars 22 forks source link

RPC discussion #11

Closed oyeb closed 8 years ago

oyeb commented 8 years ago

Generate the docs and look for a page on RPC. I'm implementing this right now as a start but any additions/deletions welcome.

oyeb commented 8 years ago

Do we need phase shifting / alignment? Phase can be configured in the beginning but the relative phase might be lost if channels are paused/resumed.

jonnew commented 8 years ago

We could add an option for phase shifting. Its my opinion that we just be consistent and not worry about how the user of the interface might find ways to abuse it in order to produce weird waveforms. It should be consistent, efficient, simple, and robust. Other than that, don't worry about holding the user's hand if they want to be stupid.

jonnew commented 8 years ago

OK, so:

Update docs to state that channel is a bit mask
Fix the typo indicating number of bits for channel bit mask in the single byte command
Add the amplitude and phase modification commands to the M-cmd-desc

and I will merge.