jonni83 / smartgarage

1 stars 1 forks source link

Incorrect access to statis members #16

Closed riverajo closed 10 years ago

riverajo commented 10 years ago

It appears that the LIGHT_ON and LIGHT_OFF have been changed to static memebers. This is the correct place for them, however they are still being accessed as instance memebers i.e. self.LIGHT_ON in the Relay class. While this will work it may confuse a reader, they should be accessed like Relay.LIGHT_ON and Relay.LIGHT_OFF

jonni83 commented 10 years ago

that's my inexperience with creating constants....