codecov-commenter
commented
1 year ago Codecov Report
Merging #180 (78fe668) into master (cd03d57) will increase coverage by
0.07%. The diff coverage is100.00%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 73.56% 73.64% +0.07%
==========================================
Files 20 20
Lines 681 683 +2
==========================================
+ Hits 501 503 +2
Misses 180 180 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/array_interface.jl | 83.50% <100.00%> (+0.34%) |
:arrow_up: |
| src/axis.jl | 85.71% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
nrontsis
As described in the title, this PR fixes tow indexing issues (#175 and #174) and adds associated tests.
Note: When indexing with zero a zero length tuple or vector of symbols a vector instead of a componentvector is returned which I find inconsistent. I didn't opt to address this in this PR, as I that it is a result of more fundamental choices regarding
_getindexand the handling of ComponentVectors with flat axes only. I plan to open a separate issue to discuss these.