search

jonniedie / ComponentArrays.jl

Arrays with arbitrarily nested named components.
MIT License
287 stars 34 forks source link

No reshape piracy #194

Closed jonniedie closed 1 year ago

jonniedie commented 1 year ago

The method

Base.reshape(A::AbstractArray, axs::NTuple{N,<:CombinedAxis}) where {N} = reshape(A, _array_axis.(axs))

commits type piracy for empty tuples since () isa NTuple{N, <:CombinedAxis} where {N}. This was introduced to fight OffsetArrays' type piracy for `reshape. We're going to revert this and only make a method for the splatted version. If someone is hitting an issue related to #123, they need to take it up with OffsetArrays

codecov-commenter commented 1 year ago

Codecov Report

Merging #194 (043b04d) into master (ed42033) will decrease coverage by 0.15%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   73.64%   73.49%   -0.15%     
==========================================
  Files          20       20              
  Lines         683      683              
==========================================
- Hits          503      502       -1     
- Misses        180      181       +1
Impacted Files Coverage Δ
src/array_interface.jl 83.33% <ø> (-0.18%) :arrow_down:
src/componentarray.jl 81.25% <0.00%> (-0.64%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more