jonniedie / ComponentArrays.jl

Arrays with arbitrarily nested named components.
MIT License
287 stars 34 forks source link

Add a missing dispatch #204

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

@avik-pal this needs fmap and thus a Functors.jl dependency. Could that be avoided somehow or is it necessary? I would guess you could turn it into a componentarray and then apply backing?

codecov-commenter commented 1 year ago

Codecov Report

Merging #204 (572d694) into master (02c95fe) will decrease coverage by 0.32%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   73.46%   73.14%   -0.32%     
==========================================
  Files          20       20              
  Lines         686      689       +3     
==========================================
  Hits          504      504              
- Misses        182      185       +3     
Impacted Files Coverage Δ
src/ComponentArrays.jl 88.88% <ø> (ø)
src/compat/chainrulescore.jl 64.28% <0.00%> (-17.54%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

avik-pal commented 1 year ago

Functors is an extremely lightweight dependency (it literally just depends on LinearAlgebra).

I would guess you could turn it into a componentarray and then apply backing?

That was my first attempt. But Tangent is not an AbstractArray so CA wouldn't flatten it.

jonniedie commented 1 year ago

Functors is an extremely lightweight dependency (it literally just depends on LinearAlgebra).

That should be fine, then.

ChrisRackauckas commented 1 year ago

This should be good to go now. Fixes the last bug in https://github.com/SciML/SciMLSensitivity.jl/pull/818