jonniedie / ComponentArrays.jl

Arrays with arbitrarily nested named components.
MIT License
291 stars 35 forks source link

Fix `recursive_eltype` not defined when constructing ComponentArray on the GPU #210

Closed ldeso closed 1 year ago

ldeso commented 1 year ago

Hi,

After the switch to Julia extensions (#192), the methods that are not exported by ComponentArrays are not accessible in the extension source files. This leads to an undefined reference when calling recursive_eltype at line 77 in the constructor of ComponentArray on the GPU:

https://github.com/jonniedie/ComponentArrays.jl/blob/97eb9e3db7904ea13b823403d00ddd9e9d6c078f/ext/ComponentArraysGPUArraysExt.jl#L76-L81

This pull request adds the missing import and fixes #209.

codecov-commenter commented 1 year ago

Codecov Report

Merging #210 (526e97d) into master (118ef79) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   73.00%   73.00%           
=======================================
  Files          20       20           
  Lines         689      689           
=======================================
  Hits          503      503           
  Misses        186      186           
Impacted Files Coverage Δ
ext/ComponentArraysGPUArraysExt.jl 52.88% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jonniedie commented 1 year ago

Thanks for this! It looks like the test failure is unrelated, so I'm gonna fix that really quick.

jonniedie commented 1 year ago

Okay, this should be good to go with the new changes. If you wouldn't mind rebasing I can merge after that.