Closed avik-pal closed 9 months ago
Merging #225 (2730051) into main (df9bd66) will decrease coverage by
0.61%
. The diff coverage is0.00%
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 73.24% 72.64% -0.61%
==========================================
Files 23 23
Lines 725 731 +6
==========================================
Hits 531 531
- Misses 194 200 +6
Files | Coverage Δ | |
---|---|---|
src/linear_algebra.jl | 78.12% <0.00%> (-18.03%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@jonniedie do you want any additional change to this?
Nope, looks good. Thanks!
it would be good to add methods for args (::Number, ::ComponentArray, ::Number, ::AbstractArray)
, and (::Number, AbstractArray, ::Number, ::ComponentArray)
MWE:
I will add tests, but unfortunately without CUDA I couldn't reproduce it since JLArrays would also hit the correct BLAS routines.