jonniedie / ComponentArrays.jl

Arrays with arbitrarily nested named components.
MIT License
286 stars 34 forks source link

add method for zygote.seed(::CA) #229

Open vpuri3 opened 9 months ago

vpuri3 commented 9 months ago

fix https://github.com/jonniedie/ComponentArrays.jl/issues/228

with this PR

julia> Zygote.hessian(x -> sum(x.a .* x.b), p)
4×4 Matrix{Float64}:
 0.0  0.0  1.0  0.0 
 0.0  0.0  0.0  1.0 
 1.0  0.0  0.0  0.0 
 0.0  1.0  0.0  0.0 
codecov-commenter commented 9 months ago

Codecov Report

Merging #229 (534ccd8) into main (d22a56c) will decrease coverage by 0.57%. The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   73.33%   72.76%   -0.57%     
==========================================
  Files          23       23              
  Lines         735      738       +3     
==========================================
- Hits          539      537       -2     
- Misses        196      201       +5     
Files Coverage Δ
ext/ComponentArraysZygoteExt.jl 40.00% <0.00%> (-60.00%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

vpuri3 commented 8 months ago

@jonniedie

jonniedie commented 8 months ago

Would you mind throwing a test case in the autodiff tests with the Hessian example you showed? (And bumping the version number)