Closed vpuri3 closed 6 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
931f411
) 73.45% compared to head (921f859
) 73.32%. Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/array_interface.jl | 55.55% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ok tests are passing on < 1.10 now. Gonna test on 1.10 next
The vcat
ambiguity in 1.10 is pretty crazy:
MethodError: vcat(::ComponentVector{Float64, Vector{Float64}, Tuple{Axis{(a = 1, b = 2:3, c = ViewAxis(4:10, Axis(a = ViewAxis(1:3, Axis(a = 1, b = 2:3)), b = 4:7)))}}}, ::ComponentVector{Float64, Vector{Float64}, Tuple{Axis{(a = 1, b = 2:3, c = ViewAxis(4:10, Axis(a = ViewAxis(1:3, Axis(a = 1, b = 2:3)), b = 4:7)))}}}, ::ComponentVector{Float64, Vector{Float64}, Tuple{Axis{(a = 1, b = 2:3, c = ViewAxis(4:10, Axis(a = ViewAxis(1:3, Axis(a = 1, b = 2:3)), b = 4:7)))}}}) is ambiguous.
Candidates:
vcat(x::ComponentVector, args...)
@ ComponentArrays ~/work/ComponentArrays.jl/ComponentArrays.jl/src/array_interface.jl:61
vcat(x::ComponentVector, args::Union{Number, UniformScaling, AbstractVecOrMat}...)
@ ComponentArrays ~/work/ComponentArrays.jl/ComponentArrays.jl/src/array_interface.jl:62
vcat(x::ComponentVector, args::Vararg{AbstractVector{T}, N}) where {T, N}
@ ComponentArrays ~/work/ComponentArrays.jl/ComponentArrays.jl/src/array_interface.jl:63
vcat(X::Union{Number, AbstractVecOrMat{<:Number}}...)
@ SparseArrays /opt/hostedtoolcache/julia/1.10.0-beta3/x64/share/julia/stdlib/v1.10/SparseArrays/src/sparsevector.jl:1229
vcat(A::Union{Number, AbstractArray, UniformScaling}...)
@ LinearAlgebra /opt/hostedtoolcache/julia/1.10.0-beta3/x64/share/julia/stdlib/v1.10/LinearAlgebra/src/uniformscaling.jl:428
vcat(A::Union{AbstractArray, UniformScaling}...)
@ LinearAlgebra /opt/hostedtoolcache/julia/1.10.0-beta3/x64/share/julia/stdlib/v1.10/LinearAlgebra/src/uniformscaling.jl:426
vcat(A::Union{Number, AbstractArray}...)
@ Base abstractarray.jl:1992
vcat(A::AbstractArray...)
@ Base abstractarray.jl:1991
vcat(A::AbstractVecOrMat...)
@ Base abstractarray.jl:1682
vcat(V::AbstractVector...)
@ Base abstractarray.jl:1612
vcat(A::AbstractVecOrMat{T}...) where T
@ Base abstractarray.jl:1683
vcat(V::AbstractVector{T}...) where T
@ Base abstractarray.jl:1613
To resolve the ambiguity, try making one of the methods more specific, or adding a new method more specific than any of the existing applicable methods.
@jonniedie can you help with ^?
Might not be able to get to this today. But how are other array packages handling it? Seems like everyone should be hitting the same problem.
which packages are you talking about?
I made the methods more specific, and tests are passing locally
@jonniedie looks like this is good to go. Bumping version.
all comments have been resolved
@jonniedie can we merge?
Sorry for the delay, was busy with school work. @jonniedie addressed your latest comment
@jonniedie
@jonniedie
@jonniedie
@jonniedie ping
Thanks for doing this. One last ask, though: would you mind making a test case of the example you gave above so this will have coverage?
To avoid conflict with
https://github.com/JuliaSparse/SparseArrays.jl/blob/main/src/sparsevector.jl#L1242-L1247
without this PR:
with this PR: