jonniedie / ComponentArrays.jl

Arrays with arbitrarily nested named components.
MIT License
286 stars 34 forks source link

Avoiding Type Piracy in Lux #246

Closed avik-pal closed 4 months ago

avik-pal commented 4 months ago

Once upon a time before package extensions, I had put in hacks in Lux to make several of the DL packages play well with ComponentArrays. We moved some of them here before, but some still remained and it seems bad to have a different behavior for these packages before and after Lux is loaded.

I am moving those patches here. Let, me know if there is an objection regarding any of them.

TODOs

Fixes https://github.com/LuxDL/Lux.jl/issues/482

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 74.09%. Comparing base (fac804d) to head (a4e5293).

Files Patch % Lines
ext/ComponentArraysReverseDiffExt.jl 50.00% 6 Missing :warning:
src/compat/chainrulescore.jl 72.72% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #246 +/- ## ========================================== + Coverage 73.88% 74.09% +0.20% ========================================== Files 23 25 +2 Lines 743 772 +29 ========================================== + Hits 549 572 +23 - Misses 194 200 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 4 months ago

@jonniedie let me know if there is any patch you don't want here.

avik-pal commented 4 months ago

Bump