search

jonniedie / ComponentArrays.jl

Arrays with arbitrarily nested named components.
MIT License
286 stars 34 forks source link

Mat index bug #249

Open dingraha opened 4 months ago

dingraha commented 4 months ago

See discussion in this issue: https://github.com/jonniedie/ComponentArrays.jl/issues/248

dingraha commented 4 months ago

@jonniedie polite ping re: this PR.

dingraha commented 3 months ago

@jonniedie Another polite ping re: this PR. :-) It's ready to go from my perspective.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.07%. Comparing base (fac804d) to head (b43853b). Report is 2 commits behind head on main.

Files Patch % Lines
src/axis.jl 88.88% 1 Missing :warning:
src/componentindex.jl 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #249 +/- ## ========================================== + Coverage 73.88% 74.07% +0.18% ========================================== Files 23 25 +2 Lines 743 787 +44 ========================================== + Hits 549 583 +34 - Misses 194 204 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dingraha commented 3 months ago

@jonniedie Another polite ping re: this PR. :-)