search

jonniek / mpv-playlistmanager

Mpv lua script to create and manage playlists
The Unlicense
537 stars 42 forks source link

[Bug] url title reverts to file name #108

Closed 2084x closed 1 year ago

2084x commented 1 year ago

To reproduce:

  1. open two or more urls with mpv and open the playlist to check titles have resolved

pic-selected-221213-1224-21

  1. wait for first video to end or hit playlist next or hit enter on a playlist entry
  2. open playlist again and first entry will just be the file name

pic-selected-221213-1224-30

This is caused by https://github.com/jonniek/mpv-playlistmanager/commit/f00137a91d97cbcbd211b9312a2b4e4b338002fe. Revert to file-loaded and the url will resolve. This issue doesn't occur with local files as far as I know.

jonniek commented 1 year ago

Seems like the media title is not set yet at this point, since the url is still loading. I feel like there is a lot of issues that have stemmed from that start-file change.

I think reverting might cause some other issues since we have adjusted the code a few times already.

I think the correct fix is maybe to have both start-file and file-loaded.

jonniek commented 1 year ago

Made a quick fix. Will take a closer look what belongs in which event later.