jonniek / mpv-playlistmanager

Mpv lua script to create and manage playlists
The Unlicense
537 stars 42 forks source link

page move down or up does not work #115

Closed ghost closed 1 year ago

ghost commented 1 year ago

title say as it

jonniek commented 1 year ago

By not work do you mean nothing happens?

For me it moves up or down by the showamount which I assume was expected behaviour of the person who implemented it.

It has a weird effect when playlist is sliced from beginning and end though. Since the selection is in the middle and the logical page down would be ceiling(showamount / 2) for showamount of odd numbers. Is this what you would expect?

For example:

  ...
  File10
  File11
->File12
  File13
  File14
  ...

Would you expect page up and down to always jump to the next file in ...?

ghost commented 1 year ago

Ah I guess I misunderstood, my expectation was that I couldn't see which video to select because the list didn't fit on the screen, so I thought we were going to use pg down to bring that list down, fortunately I solved the problem by changing the size of the font, thank you for the help

jonniek commented 1 year ago

Yeah that's an annoying issue. I brought down the default showamount as a quick fix d43619d0b6612e78d12cd271e17c2fb77962109d with some improvements to the rendering logic.

There is a duplicate #106 so I'll close this one.

tupo2 commented 1 year ago

For me, with the last commit it only shows 8 entries instead of 9 by default.

jonniek commented 1 year ago

For me, with the last commit it only shows 8 entries instead of 9 by default.

I changed it to count the .... This way the playlist will always be at most showamount lines long instead of sometimes growing and shrinking.