jonniek / mpv-playlistmanager

Mpv lua script to create and manage playlists
The Unlicense
537 stars 42 forks source link

Add screen dim #96

Closed 2084x closed 1 year ago

2084x commented 1 year ago

Can increase readability of playlist items. Set to 0.0 (no dim) by default.

Also cleaned up the config to have some continuity.

ma-zsola commented 1 year ago

Nice feature. I have issues with it when I open the playlist on fullscreen (Audio device underrun detected). Probably the calculated values are too big.

I managed to solve the issue by changing line 468:

local w, h = mp.get_osd_size()`

To this

local _, _, a = mp.get_osd_size()
local h = 360
local w = h * a
hooke007 commented 1 year ago

increase readability of playlist items

For me, the function of style_ass_tags is robust enough. You could set the style by this option. It's unnecesssary to add the screen diming at the same time.

2084x commented 1 year ago

Permission to use this feature was given here: https://github.com/christoph-heinrich/mpv-quality-menu/commit/501794bfbef468ee6a61e54fc8821fe5cd72c4ed

I should've just asked before opening the pr :facepalm:

Also added these lines as suggested:

local _, _, a = mp.get_osd_size()
local h = 360
local w = h * a
dyphire commented 1 year ago

It looks good for me, but you also need to merge these commits into one.

2084x commented 1 year ago

you also need to merge these commits into one.

how do I do this?

jonniek commented 1 year ago

I can squash and merge from Github