jonnii / chinchilla

Making RabbitMq More Awesome!
Apache License 2.0
39 stars 11 forks source link

feature/Protobuf serializers #69

Closed bieri closed 8 years ago

bieri commented 8 years ago

Addition of protobuf v3 serializers for Chinchilla. Please review the serializer file for the MessageWrapper class which seems unnecessary.

review-ninja commented 8 years ago

ReviewNinja

jonnii commented 8 years ago

@bieri actually, let me know when you're happy with this, i will merge it and maybe make a few small follow up changes.

bieri commented 8 years ago

@jonnii updated everything based on the comments and made what I think are the required changes for the builds. I don't see the tests being run in the the default.ps1 file for any of the serializers

task Test -depends Clean,CopyTools,Compile { 
  # run specs
  ..\src\packages\Machine.Specifications.Runner.Console.0.9.2\tools\mspec-clr4.exe .\..\targets\specifications\chinchilla.specifications.dll
  ..\src\packages\Machine.Specifications.Runner.Console.0.9.2\tools\mspec-clr4.exe .\..\targets\specifications\chinchilla.api.specifications.dll

  # run integration tests somehow (need a local nunit-console.exe, or switch to xunit?)
}

so I did not update. Please let me know if you see anything else to change here.

Please verify the wording in the README.md, I tried reading it to myself in an accent but it still didnt sound like the rest of it.

jonnii commented 8 years ago

@bieri lolz. will get this done for you tomorrow.

bieri commented 8 years ago

If you want everything in a single commit, i have rebase'd on this branch and we can pull from there.

bieri commented 8 years ago

I am confident that the build is failing because the protobuf package requires the -pre flag to pull it from Nuget, but I couldn't look at the settings to find out.

jonnii commented 8 years ago

@bieri merged.

jonnii commented 8 years ago

@bieri i've published a new chinchilla package, but i cannot publish the protobuf as a non-pre-release package as it depends on a pre-release package. Once Google.Protofbuf isn't pre-release any more i can cut another version for you.

bieri commented 8 years ago

@jonnii i'm good with that