search

jonnii / chinchilla

Making RabbitMq More Awesome!
Apache License 2.0
39 stars 11 forks source link

Support .NET Standard #82

Closed cocowalla closed 6 years ago

cocowalla commented 8 years ago

It would be nice to support .NET Standard as well as .NET Framework, so Chinchilla would run on .NET Core.

I've ran the Portability Advisor on the Chinchilla assembly, and the only issue was with DefaultMessageTypeFactory, which does some stuff with reflection and app domains that is no longer supported in .NET Standard.

I would do this, but I've been away from Chinchilla for quite a while, and am not very familiar with the code base any more. And looking at DefaultMessageTypeFactory it's rather difficult for me to decipher what it's doing :)

jonnii commented 8 years ago

Heyo! Welcome back! I would also like to get this working with core, but haven't yet had the time to figure it all out. I'm personally waiting for the visual studio tooling to be a bit better as hopefully it'll come with an automated way of porting a project to core. Have you ported a project before? I'd be happy to figure out a better way to get DefaultMessageTypeFactory working (maybe using expression trees?) if that would help. I'm just not exactly sure where to start with porting a project to core....

cocowalla commented 8 years ago

I have ported a couple of projects, using this and this as guides - it was surprisingly painless. An alternative approach in DefaultMessageTypeFactory would certainly help :)

jonnii commented 8 years ago

@cocowalla so what the default message type factory does is generate an implementation of an interface so you can subscribe to an interface, and not to an implementation. This can be useful for messaging versioning. I'm sure something similar is possible in core, I'll give it a whirl.

jonnii commented 6 years ago

@cocowalla i'm going to close this, we have a net standard build now.