search

jonnnnyw / php-phantomjs

Execute PhantomJS commands through PHP
MIT License
1.44k stars 432 forks source link

Use php-phantomjs in a separate project ? #192

Open bastos71 opened 7 years ago

bastos71 commented 7 years ago

Hi everyone,

I tried to install php-phantomjs on a Symfony 3.3 project, that use also twig ^2.0 (but I could set ^1.0 without any problem I think). My problem is that the requirements of the bundle does not match with Symfony 3.3 and Twig 2 :/

So here is my question : will there be a new release soon that will be compatible with symfony 3.3 ? If this is not the case, should I create another project that will be able to install php-phantomjs (of course the only purpose of this new project would be to test my main project) ?

Thx !

c9s commented 7 years ago

See #195 and https://github.com/c9s/php-phantomjs

bastos71 commented 7 years ago

Will the pull request include a modification concerning Symfony 3.3 in the composer.json ?

Actually depedencies specify "~3.0" in the versions.

c9s commented 7 years ago

I can fix that in my repo

bastos71 commented 7 years ago

Thx !

c9s commented 7 years ago

@bastos71 I've updated my repo, please take a look.

bastos71 commented 7 years ago

@c9s Thank you ! Sounds good, I will giv it a try and give you a feed back as soon as possible.