search

jonnnnyw / php-phantomjs

Execute PhantomJS commands through PHP
MIT License
1.44k stars 432 forks source link

Tests fail because of missing server #277

Open steveWinter opened 4 years ago

steveWinter commented 4 years ago

I'm wanting to verify that a fork of this project is compatible with Symfony 5 prior to submitting a PR to bring this library up to date, however many of the tests fail because the server http://www.jonnyw.kiwi/ no-longer exists and so doesn't return the expected content.

I'd be happy to host the test files (and submit a PR to update the tests) if you can provide me with access to the source of the various test files?

alistair-soreal commented 2 years ago

@steveWinter Did you ever make any progress on this?

steveWinter commented 2 years ago

@alistair-soreal nope 'cause I never heard anything back on this, so I was never able to run the tests. TBH I don't now remember what I was wanting to use this library for so I'm going to close this.

jonnnnyw commented 2 years ago

@alistair-soreal @steveWinter I have created a repo with the old test files if you want to fix the tests.

alistair-soreal commented 2 years ago

@jonnnnyw Amazing thanks!