search

jonny-rimek / wowmate

combatlog analysis for world of warcraft players
http://wowmate.io
MIT License
4 stars 0 forks source link

BlockAll on website bucket #387

Closed jonny-rimek closed 3 years ago

github-actions[bot] commented 3 years ago 
Stack wm
IAM Statement Changes
┌───┬───────────────────────────┬────────┬──────────────┬───────────┬───────────┐
│   │ Resource                  │ Effect │ Action       │ Principal │ Condition │
├───┼───────────────────────────┼────────┼──────────────┼───────────┼───────────┤
│ - │ ${Frontend-/Bucket.Arn}/* │ Allow  │ s3:GetObject │ *         │           │
└───┴───────────────────────────┴────────┴──────────────┴───────────┴───────────┘
(NOTE: There may be security-related changes not in this list. See https://github.com/aws/aws-cdk/issues/1299)

Resources
[-] AWS::S3::BucketPolicy FrontendBucketPolicy9C3048D5 destroy
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] AWS::S3::Bucket Frontend-/Bucket FrontendBucket14D51EE9 
 └─ [+] PublicAccessBlockConfiguration
     └─ {"BlockPublicAcls":true,"BlockPublicPolicy":true,"IgnorePublicAcls":true,"RestrictPublicBuckets":true}
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "54038e3067aabd77f9a033305db7cfe5b910b470531177997a0e0e1144ac10e5.zip"
        [+]   "d74716bf712bc78b95a7b5bff286a3829f4ea98abf8bf037a55a73ba3da4e7a0.zip"
        [ ] ]
github-actions[bot] commented 3 years ago 
Stack wm
IAM Statement Changes
┌───┬───────────────────────────┬────────┬──────────────┬───────────┬───────────┐
│   │ Resource                  │ Effect │ Action       │ Principal │ Condition │
├───┼───────────────────────────┼────────┼──────────────┼───────────┼───────────┤
│ - │ ${Frontend-/Bucket.Arn}/* │ Allow  │ s3:GetObject │ *         │           │
└───┴───────────────────────────┴────────┴──────────────┴───────────┴───────────┘
(NOTE: There may be security-related changes not in this list. See https://github.com/aws/aws-cdk/issues/1299)

Resources
[-] AWS::S3::BucketPolicy FrontendBucketPolicy9C3048D5 destroy
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] AWS::S3::Bucket Frontend-/Bucket FrontendBucket14D51EE9 
 ├─ [+] PublicAccessBlockConfiguration
 │   └─ {"BlockPublicAcls":true,"BlockPublicPolicy":true,"IgnorePublicAcls":true,"RestrictPublicBuckets":true}
 └─ [~] Metadata
     └─ [~] .cfn_nag:
         └─ [~] .rules_to_suppress:
             └─ @@ -6,5 +6,9 @@
                [ ]   {
                [ ]     "id": "W41",
                [ ]     "reason": "this is a website bucket, it needs to be public, so there is no point in encrypting it"
                [+]   },
                [+]   {
                [+]     "id": "W51",
                [+]     "reason": "this is a website bucket, it doesn't need a bucket policy"
                [ ]   }
                [ ] ]
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "54038e3067aabd77f9a033305db7cfe5b910b470531177997a0e0e1144ac10e5.zip"
        [+]   "d74716bf712bc78b95a7b5bff286a3829f4ea98abf8bf037a55a73ba3da4e7a0.zip"
        [ ] ]