jonnymaserati / welleng

A collection of Wells/Drilling Engineering tools, focused on well trajectory planning for the time being.
Apache License 2.0
111 stars 31 forks source link

Is this right? #162

Open zhaoyipeng opened 9 months ago

zhaoyipeng commented 9 months ago

The 1098-1117 lines of tool_error.py are as follows

    init_error = []  
    for i, (u, l) in enumerate(zip(
        error.survey.inc_rad[1:], error.survey.inc_rad[:-1]
    )):
        init_error.append(0.0)
        if all((
            u > kwargs['header']['XY Static Gyro']['End Inc'],
            l <= kwargs['header']['XY Static Gyro']['End Inc']
        )):
            for tool in kwargs['errors'].gyro_stationary:
                temp = kwargs['errors'].errors[tool].e_DIA[i - 1][2]
                if tool in ['GXY_RN']:
                    temp *= kwargs['header']['Noise Reduction Factor']
                init_error[-1] += temp

    temp = [0.0]
    for i, (u, e) in enumerate(zip(dpde[1:, 2], init_error)):
        temp.append(0.0)
        if u != 0.0:
            temp[-1] += np.sqrt(temp[-2] ** 2 + u * mag)

in these code, "init_error" totally unused, and the function name is "GXY_GRW", why "GXY_RN" used in code

jonnymaserati commented 8 months ago

@zhaoyipeng this code was experimental and shouldn't be used - it was a start and I never finished it off.