Moving import of visualization library inside of function

jonnymaserati / welleng

A collection of Wells/Drilling Engineering tools, focused on well trajectory planning for the time being.

Apache License 2.0

113 stars 31 forks source link

Open senickel opened 3 months ago

senickel commented 3 months ago

This will prevent the installation of additional packages on linux when not using visualizations (e.g., when working running code in a container).

jonnymaserati commented 3 months ago

Don't forget to bump the __version__ number in .version.

senickel commented 2 months ago

Hi @jonnymaserati! I finally have some time to review your comments. Thanks a lot for responding and for the great library as well!

Somehow your comments are not referencing any particular code lines on my side. Hence, where I wasn't sure what the comment was about I added :eyes:

I also changed visual.py to raise an ImportError if the vtk or vedo are not installed but are needed to execute something.

Let me know what you think!