search

jonnyreeves / as3-vanilla

Extract strongly typed Objects from dynamic objects without writing a single line of code!
http://www.jonnyreeves.co.uk/2011/08/getting-started-with-vanilla/
MIT License
81 stars 15 forks source link

As3Vanilla - added caching and Enum support #8

Open natami opened 10 years ago

natami commented 10 years ago

Hi, Jonny!

I previously asked, if you could add Enum support to our As3Vanilla project - knowing you are probably very busy, I added support for Java style Enums and implemented InjectionMap caching support.

Hope you can find the time to merge my changes into your project.

Regards, Soren Jepsen

natami commented 10 years ago

Hi, Jonny!

I fixed a couple of errors etc. that popped up during daily use of your As3Vanilla project.

matej-snivam commented 10 years ago

How to use this?

natami commented 10 years ago

Take a look at the docs at: https://github.com/natami/as3-vanilla

matej-snivam commented 10 years ago

nice, thx

Matej Šimunić

On 4 July 2014 00:58, natami notifications@github.com wrote:

Take a look at the docs at: https://github.com/natami/as3-vanilla

— Reply to this email directly or view it on GitHub https://github.com/jonnyreeves/as3-vanilla/pull/8#issuecomment-47993616.

natami commented 10 years ago

Fixed :)

jonnyreeves commented 10 years ago

Sorry for not getting back to you sooner natami - it's been quite a crazy year so far, new house and my wife has just had our first child; things are only starting to settle down now :)

Thanks for the PR; you've put a lot of work in here! Could you please revisit the formatting and ensure that you use the same style as the original code, this will make it much easier to review.

Thanks again Jonny.

natami commented 10 years ago

Hi, Jonny!

That’s quite all right - other stuff is just more important than keeping a project in sync on Github ;)

I’ll adjust the formatting in Intellij, so i can follow your style.

And congrats on the house and family ;)

Regards, Søren.

On 06 Jul 2014, at 21:29, John Reeves notifications@github.com wrote:

Sorry for not getting back to you sooner natami - it's been quite a crazy year so far, new house and my wife has just had our first child; things are only starting to settle down now :)

Thanks for the PR; you've put a lot of work in here! Could you please revisit the formatting and ensure that you use the same style as the original code, this will make it much easier to review.

Thanks again Jonny.

— Reply to this email directly or view it on GitHub.

natami commented 10 years ago

Ok, fixed the remaining formatting issues.

jonnyreeves commented 10 years ago

Hey @natami, sorry to be a pain, but could you use tabs, not spaces?

natami commented 10 years ago

Quite allright.

Always used intelliJ defaults. Should be fixed now.

jonnyreeves commented 10 years ago

Thanks @natami, there's still a great deal of change; I'm guessing you re-formatted the code based on your IDE's formatting rules? It makes it really hard to diff.

I'm not actually working with flash anymore and don't really plan to add more features to vanilla (and provide support fro them) - do you have any thoughts on taking ownership / maintaining your own fork of this project to provide that support.

smival commented 10 years ago

Hi, thanks for sharing! Can you suggest some way to solve my issue: I have Array of custom objects. Of course each Array contains only one objects type.

natami commented 10 years ago

Hi, Smival!

Try changeing the array to a vector.<> type...

Should solve your issue.

natami commented 10 years ago

Hi, Jonny!

Sorry for not getting back to you with a timely answer - work has been crazy over the summer.

As things are settling down and i'm getting a bit more time for personal projects, and i am interested in possibly taking ownership/support over the project - if that is okay with you?

Regards