Closed TomHoenderdos closed 5 years ago
Thanks again, Tom! Would you be interested in becoming a collaborator?
You're right about distillery
behavior, regarding deps. I don't believe exrm
was ever quite so forgiving; it seemed we had to put everything in applications
to ensure all dependencies were included.
As for adding snmp
to mix.exs
instead of snmp_ex
, I think we should take care of that for the user. This means we should instead add snmp
to our own extra_applications
and let the user just include snmp_ex
as a dependency.
Finally, with respect to moving env
from mix.exs
into config.exs
, I fear a stale build environment may actually be fooling you into thinking snmp_ex
's config is preserved. If you mix clean --deps
, you should find that the snmp_ex
config is actually never introduced. For config override behavior to work in the dependent project, using env
in mix.exs
is an easy trick, but distillery
may have a better way for dealing with such things.
Let me know what you think.
Here is what I'm thinking: #38
using :snmp_ex is not necessary as it's already in the deps Adding :snmp is necessary when distilling an application to run on a server
Add some extra info to readme Change location of configuration