jonnyzzz / TeamCity.GitHub

Integration of TeamCity and GitHub
216 stars 63 forks source link

Add a failure status condition and report #78

Closed paradox460 closed 9 years ago

paradox460 commented 9 years ago

This allows github to report 3 states, Success, Failure, and Error.

Previously, only Success and Error were reported.

This should resolve #77

Its the first Java I've written in half a decade, so hopefully it looks and works ok

Thanks!

jonnyzzz commented 9 years ago

Does it works for you?

paradox460 commented 9 years ago

It doesn't appear to. Sorry about that.

Like I said, I haven't written Java in half a decade, and my skills were never very good with it at all, unfortunately. Hopefully you can see what I was trying to do and manage to implement it.

If you do, thats awesome. If not, I understand

Thanks.


I got one of my colleagues who knows java to take a look at it, and I'll update this as I find out if my changes are feasible or not.

paradox460 commented 9 years ago

Doesn't actually work right, but we're getting there. Right now it reports error for any build :(

jonnyzzz commented 9 years ago

Thank you for the next attempt. I still believe the code will not compile. It should not be too complicated to try the build. Currently the plugin uses IntelliJ project model.

I'll try to take a look to your changes from IntelliJ to make it workable.

paradox460 commented 9 years ago

@iguanajazz was able to get it to compile, and gave me an archive to stick on our server. It "worked", in that it didn't crash, but didn't work in that it sent the wrong statuses to github.

We'll take another look at it later today and hopefully have something actually working by then :D

paradox460 commented 9 years ago

I've got it working, and I'm currently using it on my server, with no adverse effects. It compiles properly now too

jonnyzzz commented 9 years ago

Thanks! I'll check it and merge!

jonnyzzz commented 9 years ago

I checked and merge the fix. Thank you once more for it! The next build will include it