jonnyzzz / TeamCity.Node

Node.js, NPM and Phantom.JS runners for TeamCity
Apache License 2.0
309 stars 49 forks source link

I think the Gulp runner doesn't handle Spaces in agent working directory? #106

Open ashtonian opened 8 years ago

ashtonian commented 8 years ago

I believe I'm having a problem with spaces in the build agent's directory path for the gulp runner. The output is as following:

[Step 6/7] Executing D:\TeamCity\agents\TeamCity Build Agent 1 (Stuart)\BuildAgent\work\c09ad576ed797fb4\source\someApp\node_modules\.bin\gulp.cmd via wrapping shell script
[15:14:17][Step 6/7] Starting: cmd /c "D:\TeamCity\agents\TeamCity Build Agent 1 (Stuart)\BuildAgent\work\c09ad576ed797fb4\source\someApp\node_modules\.bin\gulp.cmd" --no-color "--teamcity.properties.all=D:\TeamCity\agents\TeamCity Build Agent 1 (Stuart)\BuildAgent\temp\agentTmp\teamcity5287552443166195374.json" "--teamcity.properties=D:\TeamCity\agents\TeamCity Build Agent 1 (Stuart)\BuildAgent\temp\agentTmp\teamcity6885222821638861334.json" default
[15:14:17][Step 6/7] in directory: D:\TeamCity\agents\TeamCity Build Agent 1 (Stuart)\BuildAgent\work\c09ad576ed797fb4\source\someApp
[15:14:17][Step 6/7] 'D:\TeamCity\agents\TeamCity' is not recognized as an internal or external command,
[15:14:17][Step 6/7] operable program or batch file.
[15:14:17][Step 6/7] Process exited with code 1
tengl commented 6 years ago

We have the exact same issue now. Fortunately we can disable that agent and use others, but it should be fixed anyway.

DerDreschner commented 5 years ago

We experience the same issue after installing nvm-windows on our build servers into C:\Program Files\nvm. Would be great to get an fix for that issue in the future! :)

[20:01:24]Step 1/7: Set Node Version 8.9.4 (Node.js NVM Installer) (2s)
[20:01:24]Download: Fetching NVM (1s)
[20:01:24]Downloading creatonix/nvm...
[20:01:24]from https://github.com/creationix/nvm/archive/v0.7.0.zip
[20:01:26]NVM downloaded into C:\BuildAgent\system\jonnyzzz.nvm
[20:01:26]Install: Installing Node.js v8.9.4
[20:01:26]Starting: D:\TCBuildAgent\temp\agentTmp\custom_script6116987364866104114.cmd
[20:01:26]in directory: C:\BuildAgent\system\jonnyzzz.nvm
[20:01:27]Version 8.9.4 is already installed.
[20:01:27]Process exited with code 0
[20:01:27]Use: Selecting Node.js v8.9.4
[20:01:27]Starting: D:\TCBuildAgent\temp\agentTmp\custom_script914166534282904116.cmd
[20:01:27]in directory: C:\BuildAgent\system\jonnyzzz.nvm
[20:01:27]exit status 1: 'C:\Program' is not recognized as an internal or external command,
[20:01:27]operable program or batch file.
[20:01:27]
[20:01:27]Process exited with code 0