Windows Containers Support

jonnyzzz / TeamCity.Virtual

Docker and Vagrant build runners plugin for TeamCity

http://blog.jonnyzzz.name

Apache License 2.0

84 stars 26 forks source link

Windows Containers Support #50

Open Elufimov opened 7 years ago

Elufimov commented 7 years ago

Hi! It would be great to have a support of native windows containers. Do you have any plans for it?

jonnyzzz commented 7 years ago

Do you see what should we change in the plugin for that?

docker client detection for all OS version
docker info instrospection (to let ones select agents with correct docker deamon, but DOCKER_HOST)

anything else?

Let's have issues for each of such tasks to simplify the process

Elufimov commented 7 years ago

Right now docker exist on Linux: Linux containers (full native) Windows: Linux containers (as hyper-v vm, but shared folders work fine), Windows containers (full native) macOS: Linux containers (as tiny vm, but shared folders work fine) We can find out container engine type by parsing docker version. Windows containers:

Server:
OS/Arch:      windows/amd64

All the rest containers:

Server:
OS/Arch:      linux/amd64

Elufimov commented 7 years ago

For windows containers maybe a good idea will be give user a choice between cmd and powershell shells.

beaudryj commented 7 years ago

yes something other than /bin/bash or /bin/sh

same for vagrant as well - https://github.com/jonnyzzz/TeamCity.Virtual/issues/10

Elufimov commented 7 years ago

@beaudryj you can join https://github.com/jonnyzzz/TeamCity.Virtual/pull/51 Right now we agree to implement only cmd shell. The idea is that you can call others shells via the basic ones (sh, bash, cmd).