search

jonobr1 / stalactite

stalactite is a jQuery plugin that packs child elements together.
http://jonobr1.github.com/stalactite
154 stars 32 forks source link

Margins not being taken into account #2

Closed alex-ketch closed 11 years ago

alex-ketch commented 11 years ago

When calculating the y offset, Stalactite does not take margins into account.

While replacing outerHeight() and outerWidth() with outerHeight(true) and outerWidth(true) fixes this, then the .offset parameter's limitation doesn't allow calculating of margins.

jonobr1 commented 11 years ago

Thanks for posting the issue. I think I've made a fix, but would love to see an example to test it. Do you have a codepen or jsdoit example?

This is the latest version with that fix implemented: https://github.com/jonobr1/stalactite/commit/348070d201bbdaa0aa6e3d2317a1b71bd8c3760e

jonobr1 commented 11 years ago

Since I haven't heard back, I'm going to mark this as closed.