jonobr1 / stalactite

stalactite is a jQuery plugin that packs child elements together.
http://jonobr1.github.com/stalactite
154 stars 32 forks source link

Appending new elements #3

Closed lordaugustus closed 11 years ago

lordaugustus commented 11 years ago

Is it possible to append new elements to existing container while filling the gaps? i.e. called stalactite on container, then append new elements

jonobr1 commented 11 years ago

Yes, but you will have to call stalactite again. e.g:

Stalactite. Add elements. Stalactite.

I'm not at my computer but the script should know which elements have already been calculated and skip those.

On Sunday, May 19, 2013, fc23229 wrote:

Is it possible to append new elements to existing container while filling the gaps? i.e. called stalactite on container, then append new elements

— Reply to this email directly or view it on GitHubhttps://github.com/jonobr1/stalactite/issues/3 .

http://jonobr1.com/ jonobrandel@gmail.com

lordaugustus commented 11 years ago

Hello jonobr1, this may not be related to the above, but as I read the source code I see there is a section about
// Make sure all the elements are loaded before we start packing Does that section check if all the images are fully loaded? I am not sure because it seems a great advantage of this plugin is the lazy nature which suggest you don't wait for all images to be downloaded before rendering.

I commented out the if clause there and go straight to pack($this, calculateOffset, params, options); and it seems to work fine. Is it suppose to work okay that way?

jonobr1 commented 11 years ago

Yes, that section waits until all the images are loaded before packing. It should work fine without it, but it will most likely calculate the dimensions of images before its loaded.

Hope that helps!