search

jonodrew / mentor-match

Other
3 stars 5 forks source link

Add error handler for 404 not found #105

Open jonodrew opened 2 years ago

jonodrew commented 2 years ago

This will help in the case of users asking for data that's already been deleted

jonodrew commented 2 years ago

Better late than never, some error handling!

@johnpeart is there a pre-existing 404 error page we can re-use for this?

github-actions[bot] commented 2 years ago

:white_check_mark: Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.13-final-0 ----------- Name Stmts Miss Cover
/app/init.py 22 0 100%
/app/auth/init.py 3 0 100%
/app/auth/routes.py 17 2 88%
/app/classes.py 83 3 96%
/app/config.py 10 1 90%
/app/errors/init.py 3 0 100%
/app/errors/errors.py 5 5 0%
/app/extensions.py 3 0 100%
/app/helpers.py 71 27 62%
/app/main/init.py 7 1 86%
/app/main/routes.py 127 14 89%
/app/tasks/init.py 10 2 80%
/app/tasks/helpers.py 11 4 64%
/app/tasks/tasks.py 34 0 100%
TOTAL 406 59 85%
======================= 35 passed, 45
johnpeart commented 2 years ago

We have a 404 page on the main website, here: https://github.com/civilservicelgbt/magenta/blob/main/_layouts/four-oh-four.html

Does that work?

jonodrew commented 2 years ago

That looks great! Then I think it'll just be a matter of copy-pasting it into this repo

On Sat, 25 Jun 2022, 21:25 John Peart, @.***> wrote:

We have a 404 page on the main website, here:

https://github.com/civilservicelgbt/magenta/blob/main/_layouts/four-oh-four.html

Does that work?

— Reply to this email directly, view it on GitHub https://github.com/jonodrew/mentor-match/pull/105#issuecomment-1166356223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2ATLUXF4RZMQFLJGCC46DVQ5TM3ANCNFSM5Z2I4HYA . You are receiving this because you authored the thread.Message ID: @.***>