jonodrew / mentor-match

Other
3 stars 5 forks source link

#109 implement notify #114

Closed jonodrew closed 2 years ago

jonodrew commented 2 years ago

Should fix #109

This is a great big chunk of work, and it's still not quite finished. We need a neat way to tie together the matching workflow and this notifications workflow. Ideas welcome.

However, for now, you can test this by going through the matching workflow, and then going to /notify-settings/before-you-start. From there, follow the workflow through.

ONLY USE A TEST API KEY. This service is genuinely connected to the genuine internet and will genuinely email a whole bunch of people if you tell it to.

So don't!

Okay, that's the lecture over. So @johnpeart , what do you think? I know there's more to do, but let's get it integrated now and tidy up later.

github-actions[bot] commented 2 years ago

:white_check_mark: Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.13-final-0 ----------- Name Stmts Miss Cover
/app/init.py 22 0 100%
/app/auth/init.py 3 0 100%
/app/auth/routes.py 17 2 88%
/app/classes.py 83 3 96%
/app/config.py 10 1 90%
/app/export.py 28 4 86%
/app/extensions.py 3 0 100%
/app/helpers.py 75 27 64%
/app/main/init.py 7 1 86%
/app/main/routes.py 128 14 89%
/app/notify/init.py 3 0 100%
/app/notify/routes.py 49 12 76%
/app/tasks/init.py 10 2 80%
/app/tasks/helpers.py 11 4 64%
/app/tasks/tasks.py 40 2 95%
TOTAL 489 72 85%
======================= 41 passed, 66