jonof / moodle-block_completion_progress

A time management tool for students using activity completion
https://moodle.org/plugins/block_completion_progress
GNU General Public License v3.0
17 stars 65 forks source link

Behavior of the “selected activities” configuration changed #88

Closed melanietreitinger closed 2 years ago

melanietreitinger commented 2 years ago

Since the "big sweeping code reorganisation", the behavior of the “selected activities” configuration changed:

Before: when some activities had been selected for the block, it was possible to add more activities from the course on editing the block settings. Now the other, unselected activities are not shown any more. To see them I have to change "Activities included" to “All activities with completion set”, save and then change it again for “selected activities”.

Is this inteded behaviour? And if so: why? As I see it, you can remove the lines 434-437 in classes/completion_progress.php completly.

jonof commented 2 years ago

Is this inteded behaviour?

Nope, that's a mistake. Fix coming shortly.