jonog / redalert

:rocket: continuously test all the things - trigger alerts on failure :boom:
MIT License
91 stars 16 forks source link

undefined: grpc.SupportPackageIsVersion3 #52

Closed ghost closed 7 years ago

ghost commented 7 years ago

It looks like, although you're vendoring with godep, you're not vendoring gprc and there's some version conflict resulting in redalert not building cleanly.

1077)jonog/redalert % go build             
# github.com/jonog/redalert/servicepb
servicepb/service.pb.go:157: undefined: grpc.SupportPackageIsVersion3

Is there a step missing in the documentation?

ghost commented 7 years ago

This fixes it:

diff --git a/Godeps/Godeps.json b/Godeps/Godeps.json
index 4d0b23d..f1a32e3 100644
--- a/Godeps/Godeps.json
+++ b/Godeps/Godeps.json
@@ -6,6 +6,11 @@
        ],
        "Deps": [
                {
+                       "ImportPath": "google.golang.org/grpc",
+                       "Comment": "grpc.SupportPackageIsVersion3",
+                       "Rev": "2769b6cafd5c99be849b44c08d6f09e5d2c32f8c"
+               },
+               {
                        "ImportPath": "bitbucket.org/kardianos/osext",
                        "Comment": "null-15",
                        "Rev": "44140c5fc69ecf1102c5ef451d73cd98ef59b178"
jonog commented 7 years ago

thanks @serussell - the godeps file was definitely missing quite a few deps! have now moved to glide and the Circle CI build is also using this now. Added a makefile with commands used during development, and will endeavour to improve the docs further.