jonom / jquery-focuspoint

jQuery plugin for 'responsive cropping'. Dynamically crop images to fill available space without cutting out the image's subject. Great for full-screen images.
Other
3.15k stars 211 forks source link

[BUGFIX] Enable to focus point behind bullseye by click #44

Closed ghost closed 8 years ago

jonom commented 8 years ago

Thanks but what is this fixing? Is there a browser the helper tool doesn't work in?

ghost commented 8 years ago

In Firefox 40.0.x (OS X) it is not possible to click the area in the zoom circle. Now it is possible to click directly next the the current focus point. Example attached.... now you can click the black point ;)

Regards, Tim

Am 31.08.15 um 20:13 schrieb Jono Menz:

Thanks but what is this fixing? Is there a browser the helper tool doesn't work in?

— Reply to this email directly or view it on GitHub https://github.com/jonom/jquery-focuspoint/pull/44#issuecomment-136450369.

ghost commented 8 years ago

example Example... :)

jonom commented 8 years ago

Thanks for the example, I wasn't able to replicate the problem though. The helper tool in this project works fine for me in Firefox 40.0.3 on Mac without this change, even when clicking right next to the current focus point (within the circle). Maybe it is a problem only with the Typo3 module? Can you confirm?

jonom commented 8 years ago

Firefox only appears to have support for the pointer-events property enabled by default for non-SVG elements starting at version 41 (and only in nightly builds) so I'm going to close this for now as I can't replicate the problem and it doesn't seem like this property could fix it for most users anyway - but feel free to re-open if you think this does need to be included.

ghost commented 8 years ago

Thank you... you are right. It is just a problem of the TYPO3 integration and i fix the issue in a TYPO3 related CSS file. Thank you a lot for the great lib....!! https://github.com/lochmueller/focuspoint/commit/6aca720d5558eee7c565aa9dfd43a9482070c4d2

jonom commented 8 years ago

cool :)