search

jonom / jquery-focuspoint

jQuery plugin for 'responsive cropping'. Dynamically crop images to fill available space without cutting out the image's subject. Great for full-screen images.
Other
3.15k stars 211 forks source link

changes to date #47

Closed tomByrer closed 8 years ago

tomByrer commented 8 years ago

changes to date

jonom commented 8 years ago

Thanks Tom, these changes all make sense. Do you want me to merge these soon or do you want to keep working on stuff? I know I said I prefer a single commit per issue but I don't want to merge any revert commits - so I'd be happy for you to squash all of this in to one commit if you like, call it something like 'Optimisations' and just summarise each of the things you did in the message.

jonom commented 8 years ago

Or rather, squash the last 4 in to one. May as well leave the image one separate. Or whatever :D

tomByrer commented 8 years ago

Or rather, squash the last 4 in to one. May as well leave the image one separate. Or whatever :D

Sounds like best bet. Might be day or 3.

jonom commented 8 years ago

Thanks for your efforts Tom. If there's no significant performance gain I'm not likely to merge https://github.com/tomByrer/jquery-focuspoint/commit/d94272df199586016bf8c51615778e05388368b0. There's a real benefit to me in keeping it all on an object in that I can use the console to debug data at any point and get a readout of all the vars, nicely grouped together.