search

jonom / silverstripe-betternavigator

Front-end utility menu for SilverStripe websites featuring administration and development tools
60 stars 31 forks source link

i18n support #32

Closed a2nt closed 7 years ago

wernerkrauss commented 7 years ago

Could you please also add a default en.yml? You can generate it easily using I18nTextCollector, see https://docs.silverstripe.org/en/3.0/topics/i18n/#collecting-text

a2nt commented 7 years ago

done

jonom commented 7 years ago

@a2nt unfortunately you can't target master for an SS3 change as it's already been updated for SS4. I've set up an SS3 branch for you on this repo for you to target instead. I tried switching the base of this PR to the new branch but as you will see, it's gotten all messed up.

Can you please check out the SS3 branch and replay your changes on there (from all three PRs) then open a new pull request on the SS3 branch. Please note the extra translation needed too: https://github.com/jonom/silverstripe-betternavigator/pull/32#pullrequestreview-75181324