search

jonom / silverstripe-betternavigator

Front-end utility menu for SilverStripe websites featuring administration and development tools
60 stars 31 forks source link

Conversion to a Vendor Module #40

Closed UndefinedOffset closed 6 years ago

UndefinedOffset commented 6 years ago

This pull request converts the module to a vendor module which assists with compatibility for 4.1.0 (though it does work fine with 4.0).

jonom commented 6 years ago

Thanks @UndefinedOffset. Have been away for a while and don't have time to test this myself right now - I assume you've put this change through the paces?

UndefinedOffset commented 6 years ago

Yep also just verified it also works properly through composer using our fork as well. It's exposing the folders as expected and loading properly :)

UndefinedOffset commented 6 years ago

Found one issue, looking into will update when I have a fix shouldn't take long just wanted to alert before it's merged.

UndefinedOffset commented 6 years ago

And... addressed :) so it's good to go now

jonom commented 6 years ago

Thanks!

adrexia commented 6 years ago

Awesome! Any chance we could get a release tagged with this in it? :)

jonom commented 6 years ago

Oops! Yeah... I guess a minor release should do the trick for this change? It's backwards compatible right?

adrexia commented 6 years ago

From what I understand the silverstripe-module type was what kept it out of vendor in the first place. It looks like everyone else has been using minor releases, if that helps? And vendor modules work in 4.0 and 4.1 so it should be fine :)

jonom commented 6 years ago

Cool. Have tagged a 4.1 release.