jonom / silverstripe-betternavigator

Front-end utility menu for SilverStripe websites featuring administration and development tools
60 stars 31 forks source link

Added i18n support for SS4 #48

Closed AndreasLang50 closed 3 years ago

AndreasLang50 commented 4 years ago

This pull request adds i18n translation functionality, usable with .yml Files in the lang folder as usual. I've already included the English and German translation files.

And while I was on it, I decided to add title attributes for the last links in the debugging section with the descriptions copied from the official SilverStripe Document.

Changelog:

AndreasLang50 commented 4 years ago

Yeah, you're right, I thought of it as the root scope, therefore not having any namespaces, but they do make a lot of sense. I've now put all translations into JonoM\BetterNavigator as requested.

AndreasLang50 commented 4 years ago

@jonom Any updates on this please? Thanks :)

jonom commented 4 years ago

@AndreasLang50 sorry for the delay on this! Have been super busy but it's on my to do list to check this, aiming to test and merge this week.

AndreasLang50 commented 4 years ago

Alright, thx!

jonom commented 3 years ago

Great work @AndreasLang50, thank you! Sorry for the delay in reviewing. Merged and tagged a 5.1.0 release.

AndreasLang50 commented 3 years ago

thanks :)