search

jonom / silverstripe-betternavigator

Front-end utility menu for SilverStripe websites featuring administration and development tools
60 stars 31 forks source link

Changing css to target classes instead of IDs #49

Closed 3Dgoo closed 3 years ago

3Dgoo commented 3 years ago

CSS linting now recommends targetting classes instead of IDs. This change updates the templates, sass and CSS to do this.

jonom commented 3 years ago

Thanks @3Dgoo this is appreciated but it would be a breaking change and I don't think it's pragmatic. It would create problems for anyone who is overriding the CSS and while I too would use classes if creating BetterNavigator today, I don't think it bring any real-world benefits to do a conversion here.

3Dgoo commented 3 years ago

Sure thing. Thanks for reviewing the changes and letting me know.