Closed chrispenny closed 1 year ago
Thanks for working on this @chrispenny. If you have a sec while you're dealing with namespaces you might want to take a peek at this issue, otherwise I'll aim to do that before we bump the version on this module.
Thanks, @jonom! I'll have a look today :D
Looks to be working with the suggested namespace change.
Template for each include:
New buttons added:
@jonom I believe this is ready for review :)
I've tested running my local in dev
and test
to check that the interface shows (or hides) at appropriate times, and the buttons all look to be linking correctly.
Awesome, thanks @chrispenny! Have tagged 6.0.0-beta1 and created a 5 branch.
Template namespace
Breaking change
Moved templates into
JonoM
namespace. UpdaterenderWith()
and<% include %>
references.Fixes #60 Closes #60
Upgrade actions: Developers will need to move any custom/overriding templates into a
JonoM
directory (matching what is documented in theREADME
).BetterNavigatorExtension
changesBreaking change
SilverStripeNavigator
has moved namespace in Silverstripe 5. With that being the case, I don't believe we can support Silverstripe 4 and 5 at the same time? (Though I will be happy to be wrong).shouldDisplay()
cache changeThe way that this cache was being set to a field seems to throw an error with Silverstripe 5:
Using local/mem-cache on the Extension will achieve the same result.
BetterNavigator.ss
changesIn Silverstripe 5 there is now a configuration to allow/disallow trailing slashes. For the
Build databases
andDev menu
links, it's easier to use relative links, as we then don't need to bother with checking if trailing slashes were present or not.Trailing slash change: https://github.com/silverstripe/silverstripe-framework/pull/10538