search

jonom / silverstripe-focuspoint

Module for improving automatic image cropping in SilverStripe. Adds simple art-direction control by allowing you to set and crop from a focus point instead of the centre point of an image.
MIT License
109 stars 48 forks source link

Tweak travis build #80

Closed maxime-rainville closed 4 years ago

maxime-rainville commented 4 years ago

Fixing broken build introduce in https://github.com/jonom/silverstripe-focuspoint/pull/78

jonom commented 4 years ago

FYI, I tried with ^1.6 and 1.6.x-dev and both failed.

jonom commented 4 years ago

Maybe it should just be dev-master?

maxime-rainville commented 4 years ago

The problem was that there wasn't a minimum stability define in focus-point's composer.json. So it implicitly defaulted to stable. I've tweak it to say that dev dependencies are allowed. This should allow the travis build to install the dev branches.

Note that this change won't make any difference for people installing focus point on their project. Composer only honours the minimum stability of the root composer.json file.

The build is still failing but those failures were pre-existing. I got these errors while I was developing #78 and running the test locally.

jonom commented 4 years ago

Perfect, that did the trick. Thanks for your help. Yes there was an existing build failure, going to revert the cause of that and then we'll be green again.