jonom / silverstripe-focuspoint

Module for improving automatic image cropping in SilverStripe. Adds simple art-direction control by allowing you to set and crop from a focus point instead of the centre point of an image.
MIT License
109 stars 48 forks source link

Make disabled state of picker more obvious #99

Closed micschk closed 3 years ago

micschk commented 3 years ago

Not sure where else to put this but the picker 'seems' active when viewing an image in view-mode (form disabled). Clients try to alter the focus point but this doesn't change as it's disabled. Only after clicking the 'Details' button, the focuspoint can actually be altered.

Screenshot 2021-09-10 at 15 56 06

To make this more obvious, I'd proposte we grey-out & dim the image, just like the other disabled inputs of this form; Screenshot 2021-09-10 at 15 57 44 Screenshot 2021-09-10 at 15 55 41

Achieved with some basic CSS:

#Form_fileSelectForm .focuspoint-picker {
  filter: grayscale(100%);
  opacity: .6;
}
jonom commented 3 years ago

@micschk totally feel you on this, intended do something like this but never got around to it. This has been done now, tagged 4.0.1.

micschk commented 3 years ago

Great jonom, thx!