search

jonorthwash / Apertium-Global-PairViewer

GNU General Public License v3.0
0 stars 8 forks source link

Stars now move with globe #77

Closed diogoscf closed 4 years ago

diogoscf commented 4 years ago

Final thing needed to resolve #29

The space (background), including the stars, now zooms in and out, and moves around too with the zooming and rotating of the globe.

Here is a video of the code in action

JPJPJPOPOP commented 4 years ago

@diogoscf I can't rotate the globe anymore for some reason. It's giving me TypeError: t is undefined in console.

JPJPJPOPOP commented 4 years ago

Never mind, something was wrong with my computer.

JPJPJPOPOP commented 4 years ago

@diogoscf Can you limit more how much you can zoom out because otherwise something like this happens: Screen Shot 2019-12-11 at 1 57 05 PM

JPJPJPOPOP commented 4 years ago

Also, I am still getting TypeError: stars is undefined when I first load the page.

diogoscf commented 4 years ago

You can't zoom out as much now, and there are no more errors.

JPJPJPOPOP commented 4 years ago

LGTM