jonorthwash / Apertium-Global-PairViewer

GNU General Public License v3.0
0 stars 8 forks source link

keyboard and touchscreen manipulation #8

Open jonorthwash opened 6 years ago

jonorthwash commented 6 years ago

Keyboard shortcuts and touchscreen pinch events should zoom and scroll and stuff.

JPJPJPOPOP commented 6 years ago

@jonorthwash What do you mean by keyboard shortcuts? Is it like pressing up arrow or down arrow will make it zoom in or out?

jonorthwash commented 6 years ago

Probably +/= and -. Kind of like how most map sites do it.

JPJPJPOPOP commented 6 years ago

@jonorthwash Okay, thanks!

jonorthwash commented 6 years ago

Current behaviour:

Both browsers should have full functionality in terms of zooming. Also, 0 should reset to default zoom level.

JPJPJPOPOP commented 6 years ago

@jonorthwash

Chrome: chrome

JPJPJPOPOP commented 6 years ago

@jonorthwash

I tried running the program on Safari and Chrome on my iPhone and apparently pinch to zoom does work, but for some reason, running the Chrome/Firefox dev emulators don't.

jonorthwash commented 6 years ago

There should be no difference between the default zoom level in Firefox and Chrome. Firefox:

Yeah, I can't seem to reproduce what I saw earlier...

Touchscreen rotation doesn't seem to work on either of the browsers. I believe that this is because the author originally based the drag functionality off another program that didn't have mobile drag functionality.

Wfm in firefox.

Touchscreen zoom seems to work on Firefox, but not Chrome.

Doesn't work for me in either. I have Firefox 52.5.0. Should I upgrade?

jonorthwash commented 6 years ago

apparently pinch to zoom does work,

It ~works for me in Chromium, but only in that when I pinch on the globe the whole page zooms. E.g., the zoom buttons go out of frame. Is this the behaviour you get?

JPJPJPOPOP commented 6 years ago

@jonorthwash

I've tested the functionalities on an actual phone (pinching to zoom and rotating) and they seem to work properly. For some reason, the globe turns black (probably some stuff isn't rendering properly), but I can probably fix that later. Here is a gif:

globe

Note: This is with the most recent updates, i.e. you might need to merge my PRs.

jonorthwash commented 6 years ago

I'm not getting zooming (except for page-level) or rotating on official Chrome or LineageOS's open-source browser (based on Chrome, I think).

JPJPJPOPOP commented 6 years ago

@jonorthwash @coler706

It seems that the pinch to zoom functionality still doesn't work (at least for me) on the Chrome dev tools. It does work on mobile (an actual phone) however.

jonorthwash commented 6 years ago

Zoom functionality is still problematic. @coler706, where you working on that?

JPJPJPOPOP commented 6 years ago

@jonorthwash Realized that the keyboard shortcuts don't exist anymore. I think one of Cole's commits got rid of it because I added that in before.