jonorthwash / ud-annotatrix

GNU General Public License v3.0
61 stars 49 forks source link

Complete tree appears as incomplete #319

Closed ftyers closed 6 years ago

ftyers commented 6 years ago

The tree below should be complete, the arcs should be black and the blue progress bar at the bottom should be full. It has:

  1. a head for every token
  2. a valid dependency relation for every token
  3. a valid part of speech for every token.

captura de 2018-08-22 20-15-02

keggsmurph21 commented 6 years ago

fixed in beaf0b1 screenshot from 2018-08-22 22-18-48

ftyers commented 6 years ago

What you have looks good, but I don't get the same result. I did:

git pull
npm i
npm build

is there something else I need to do, @keggsmurph21 ? Note that I am running this locally, not with a server.

keggsmurph21 commented 6 years ago

i have uncommitted changes, so maybe that's why it isn't working. i'll let you know when i commit everything

keggsmurph21 commented 6 years ago

@ftyers all changes are pushed, so let me know if that fixes the problem

i think you should be good to go running just git pull, but if that doesn't work, run npm install && npm run build and try again

ftyers commented 6 years ago

Looks good! We should probably put npm install && npm run build somewhere as default things to do after git pull otherwise people like me might get confused :D