search

jonorthwash / ud-annotatrix

GNU General Public License v3.0
61 stars 49 forks source link

Japanese text overspills in the box #324

Closed ftyers closed 4 years ago

ftyers commented 6 years ago

This is the case for both the old and new interfaces. We should make sure that all writing systems work.

japud

jonorthwash commented 5 years ago

Part of this issue is figuring out how to make the boxes scale in a way that's sensitive to the text width—and not just some calculation based on number of characters.

JPJPJPOPOP commented 4 years ago

@ftyers Can you try now? The boxes should scale based on text width, so this shouldn't be a problem anymore.

jonorthwash commented 4 years ago

Is this confirmed okay now? Could we see a screenshot?

JPJPJPOPOP commented 4 years ago

@jonorthwash I tried a variety of Japanese conllu files and they work fine. Screen Shot 2020-06-11 at 2 18 43 PM Screen Shot 2020-06-11 at 2 19 32 PM

ftyers commented 4 years ago

This looks great!

jonorthwash commented 4 years ago

Indeed, that's beautiful!