search

jonorthwash / ud-annotatrix

GNU General Public License v3.0
61 stars 49 forks source link

Chat window should be minimised by default #325

Closed ftyers closed 5 years ago

ftyers commented 6 years ago

Or even just disabled until enabled. It clutters up the interface.

jonorthwash commented 6 years ago

I had specifically asked for this, and @keggsmurph21 implemented it; this must be a recent regression.

jonorthwash commented 5 years ago

bundle.js wasn't updated in #342, so this issue remains unresolved.

jonorthwash commented 5 years ago

@yaskevich, any update on this issue?

yaskevich commented 5 years ago

It's a problem to make a bundle, because the build system of the project is outdated, its config should be completely rewritten. I've made a build script for client JS and regenerate the bundle, it seems to work properly (chat windows is closed). However, I've just changed some parts of the code base, which is to be reviewed as a whole. New bundle is in PR #348.

jonorthwash commented 5 years ago

So the script is just a short-term solution and that's why you didn't include it in the PR?

yaskevich commented 5 years ago

Not exactly, rather because I fixed only task for client UI, not those for everything. Except of this, all this stuff must be properly tested, at least manually. But when I go that deeper, it stops looking like code challenge, but rather full-fledged project development. And just during this week I am under the pressure of several deadlines, which makes switching to additional tasks superhard.

jonorthwash commented 5 years ago

@yaskevich, that's fine about how busy you are and the extent of work—I understand and am in a similar situation currently. But I want to make sure I understand everything correctly, so I'm going to list what I am understanding and ask for you to correct these statements:

  1. You wrote a script to generate a new bundle.js?
  2. You didn't commit this new script because it's a temporary solution?
  3. You don't have time right now to work on the build system (understood).
  4. You suspect that bundle.js may not have been generated correctly, so you think it should be tested more thoroughly.
yaskevich commented 5 years ago

Yes. And today I've pushed to the same PR #348 completely rewritten Gulp config (in the syntax of current Gulp 4).

jonorthwash commented 5 years ago

I merged the PR and it seems good now.